Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EO-QB updates and some QB4ST fixes #742

Merged
merged 4 commits into from
May 17, 2017

Conversation

dmitry-brizhinev
Copy link
Contributor

Addressed most of Kerry's TODO list. Details are below.

Also made some fixes to qb4st - need Rob to take a look at them to see if they are correct.

====== DONE =====

Removed :pixelPerDegree (fixes 1, 4)

Changed crs URI (fixes 2)

Created a qb4st:CRS object for the DGGS (fixes 12)

Checked qb4st for relevant updates - added CRS labels (Fixes 3)

Changed union to separate :dataImageValue and :dataPixelValue properties (fixes 6)

Removed prov:wasDerivedFrom :AGDC (fixes 20)

Changed prov:wasAssociatedWith :GeoscienceAustralia to prov:wasAttributedTo (fixes 21)

Changed names of grid squares from arbitrary "s1" and "s2" to "R000" and "R0000" (fixes 27)

===== NOT DONE COMMENTS ====

  1. "QB4ST [qb4st] does not currently have a term for that, but it may in the future."

It still does not

  1. Example 8 led:etmBand led:latMin led:longMax led:value are not in ANU-LED-example.ttl. They need to be (and they nee to be explained). LEd uses "bounds" instead. Also the example seems to be outofdate wrt QB4st in the ontology? Also it uses led:Pixel -- shouldn't it be a GridSquare (tile?).

For Sam

  1. SSN might well change its name and prefix shortly.

For Kerry

  1. Several changes to ssn in the area of example 9. Platform, observes, onPlatform, maybe hasMeasurementCapability. Should add ssn:accuracy.

For Kerry

  1. Example 13: check ssn:Property for change

For Kerry

  1. Example 14. timedomain is a time:Interval that appears to be very short (begins and ends at "2001-10-26T21:32:52) . However, it is normal for satellite imagery to instead be given a (real) time period due to the time taken to travel over the surface. I like that the particular :grid Square has only a time instant, but surely the timedomain could be longer?

I haven't acted on this yet. Sounds like this criticism would also apply to the :time dimension values on the actual data. The way it is now is pleasantly simple and I am reluctant to change it.

Dmitry Brizhinev and others added 2 commits April 25, 2017 16:21
Originally I was going to write about GeoSPARQL being difficult to
implement. It is, IMO, but the only third-party source I have is the
informal message at [0] from the Jena maintainer, so I'll leave it out
for now to save myself potential future embarrassment :-)

[0] http://users.jena.apache.narkive.com/84Qbjbcx/geosparql-and-jena
Copy link
Contributor

@rob-metalinkage rob-metalinkage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with fixes to qb4st.ttl

@BillSwirrl BillSwirrl merged commit 3eac85b into w3c:gh-pages May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants